Skip to content

aead: have getrandom enable rand_core#2452

Merged
tarcieri merged 1 commit into
masterfrom
aead/have-getrandom-enable-rand_core
Jun 17, 2026
Merged

aead: have getrandom enable rand_core#2452
tarcieri merged 1 commit into
masterfrom
aead/have-getrandom-enable-rand_core

Conversation

@tarcieri

Copy link
Copy Markdown
Member

Closes #2450

@tarcieri tarcieri merged commit 05bc110 into master Jun 17, 2026
12 checks passed
@tarcieri tarcieri deleted the aead/have-getrandom-enable-rand_core branch June 17, 2026 14:17
@newpavlov

Copy link
Copy Markdown
Member

FYI this change was part of #2427.

@tarcieri

Copy link
Copy Markdown
Member Author

...which is a change unrelated to the other changes #2427 is making, which is exactly the problem with #2427.

Perhaps there are other additive changes in there which can be extracted into small, well-scoped PRs.

@newpavlov

Copy link
Copy Markdown
Member

And perhaps you could've noticed this and "other additive changes" by properly reviewing the PR, instead of being so dismissive. As I wrote many times, I consider the PR small enough and do not like the busy work of bikeshedding micro changes. IMO it only makes the history of changes unnecessarily confusing.

But alas, what's done is done.

tarcieri added a commit that referenced this pull request Jun 17, 2026
## Changed
- Have `getrandom` feature enable `rand_core` (#2452)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants